Skip to content

Preventing methods that don't work on web to crash the app - #427

Merged
erickzanardo merged 4 commits into
developfrom
erick.preventing-web-methods-crashing
Jul 30, 2020
Merged

Preventing methods that don't work on web to crash the app#427
erickzanardo merged 4 commits into
developfrom
erick.preventing-web-methods-crashing

Conversation

@erickzanardo

@erickzanardo erickzanardo commented Jul 25, 2020

Copy link
Copy Markdown
Member

Description

Please include a summary of the change.

Fixes #361

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

If something is unclear, please submit the PR anyways and ask about what you thought was unclear.

  • This branch is based on develop
  • This PR is targeted to merge into develop (not master)
  • I have added an entry under [next] in CHANGELOG.md
  • I have formatted my code with flutter format
  • I have made corresponding changes to the documentation
    - [ ] I have added examples for new features in doc/examples
  • The continuous integration (CI) is passing

Comment thread lib/flame_audio.dart Outdated

@luanpotter luanpotter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo
erickzanardo merged commit e90d97c into develop Jul 30, 2020
@erickzanardo
erickzanardo deleted the erick.preventing-web-methods-crashing branch July 30, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants