onComplete callback for effects - #393
Merged
Merged
Conversation
erickzanardo
left a comment
Member
There was a problem hiding this comment.
Your PR is pointing to master :P
Member
Author
Fixed now! |
erickzanardo
approved these changes
Jun 24, 2020
erickzanardo
left a comment
Member
There was a problem hiding this comment.
Small nit, but LGTM already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces an onComplete callback for effects
Fixes #336
Type of change
Please delete options that are not relevant.
Checklist:
If something is unclear, please submit the PR anyways and ask about what you thought was unclear.
developdevelop(notmaster)[next]inCHANGELOG.mdflutter formatdoc/examples