Upgrade tiled and flutter_svg dependencies. - #379
Merged
Conversation
erickzanardo
approved these changes
Jun 15, 2020
erickzanardo
left a comment
Member
There was a problem hiding this comment.
Just a minor concern regarding the CHANGELOG, other than that, LGTM
luanpotter
force-pushed
the
luan.upgrade-tiled
branch
from
June 15, 2020 12:14
c003ba4 to
7530b04
Compare
| - uses: subosito/flutter-action@v1 | ||
| with: | ||
| channel: 'stable' | ||
| channel: 'dev' |
Member
There was a problem hiding this comment.
Does that means that people will require the dev channel of Flutter to use Flam?
Member
Author
There was a problem hiding this comment.
No, they will need at least 1.18.0-6.0.pre. I don't know what branch that is in at the moment. But this is a requirement introduced by flutter_svg 0.18.0, so we can't upgrade if we don't want that.
Member
There was a problem hiding this comment.
We usually, keep Flame following the beta channel, let me confirm which version is the latest beta.
Member
Author
There was a problem hiding this comment.
I just changed to dev as that's the one I use. I will try beta to see if the build works.
This was referenced Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade tiled and flutter_svg dependencies.
Fixes # (issue number, if there is one)
Type of change
Checklist:
If something is unclear, please submit the PR anyways and ask about what you thought was unclear.
developdevelop(notmaster)[next]inCHANGELOG.mdflutter formatdoc/examples