Adding Images#fromBase64 - #310
Merged
Merged
Conversation
spydon
reviewed
May 4, 2020
spydon
left a comment
Member
There was a problem hiding this comment.
LGTM, except that generated file, but maybe I just don't understand it?
| @@ -0,0 +1,16 @@ | |||
| // | |||
| // Generated file. Do not edit. | |||
Member
There was a problem hiding this comment.
I think this is a new file that all flutter projects have now but these old examples built with older flutter didn't. not sure if we should version or not but it doesn't say on the file it shouldn't be. I would look at the other newer examples to see what we do. maybe the new flutter create adds it to the gitignore.
Member
Author
There was a problem hiding this comment.
I just checked, it is on git ignore, I am going to remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a way to load images from base64 string images.