feat(firestore): count() feature for counting documents without retrieving documents. - #9699
Merged
Conversation
count() feature.count() feature for counting documents without retrieving documents.
Lyokone
reviewed
Oct 10, 2022
Lyokone
reviewed
Oct 10, 2022
Ehesp
reviewed
Oct 11, 2022
Salakar
reviewed
Oct 11, 2022
Lyokone
reviewed
Oct 11, 2022
Lyokone
reviewed
Oct 12, 2022
# Conflicts: # packages/cloud_firestore/cloud_firestore/ios/cloud_firestore.podspec
russellwheatley
marked this pull request as ready for review
October 18, 2022 09:52
Lyokone
approved these changes
Oct 18, 2022
lesnitsky
reviewed
Oct 18, 2022
| @override | ||
| AggregateQueryPlatform count() { | ||
| return MethodChannelAggregateQuery( | ||
| this, |
Contributor
There was a problem hiding this comment.
do we have a styleguide for this?
Member
Author
There was a problem hiding this comment.
We don't AFAIK, it just follows the same implementation style as the rest of the plugins.
lesnitsky
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merged first:
10.0.0update: feat!: Firebase iOS SDK version:10.0.0聽#970831.0.0update: feat!: Firebase android SDK BOM31.0.0聽#97249.11.0feat: Firebase JS web SDK version:9.11.0聽#9742DONE
website documentation- Documentation is not on FlutterFire project. Firebase will have to update this on their website.Related Issues
none.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?