test(fdc): add e2e and unit tests to fdc - #13224
Merged
Merged
Conversation
This reverts commit 6a643f1.
russellwheatley
requested changes
Sep 12, 2024
russellwheatley
left a comment
Member
There was a problem hiding this comment.
Some minor feedback but it's looking good to me 👍
| - 'docs/**' | ||
| - 'website/**' | ||
| - '**/example/**' | ||
| - '**/flutterfire_ui/**' |
Member
There was a problem hiding this comment.
Suggested change
| - '**/flutterfire_ui/**' |
| path: | | ||
| ~/.android/avd/* | ||
| ~/.android/adb* | ||
| key: avd-ubuntu |
Member
There was a problem hiding this comment.
Suggested change
| key: avd-ubuntu | |
| key: avd-${{ runner.os }} |
| - uses: hendrikmuhs/ccache-action@c92f40bee50034e84c763e33b317c77adaa81c92 | ||
| name: Xcode Compile Cache | ||
| with: | ||
| key: ${{ runner.os }}-ios-fdc-v3 |
Member
There was a problem hiding this comment.
Suggested change
| key: ${{ runner.os }}-ios-fdc-v3 | |
| key: xcode-cache-${{ runner.os }} |
Comment on lines
+37
to
+69
| final listener = MoviesConnector.instance.listMovies | ||
| .ref() | ||
| .subscribe() | ||
| .listen((value) { | ||
| final movies = value.data.movies; | ||
|
|
||
| if (count == 0) { | ||
| expect(movies.length, 0, | ||
| reason: 'First emission should contain an empty list'); | ||
| } else { | ||
| expect(movies.length, 1, | ||
| reason: 'Second emission should contain one movie'); | ||
| expect(movies[0].title, 'The Matrix', | ||
| reason: 'The movie should be The Matrix'); | ||
| hasBeenListened = true; | ||
| } | ||
| count++; | ||
| }); | ||
|
|
||
| await Future.delayed(const Duration(seconds: 1)); | ||
|
|
||
| await MoviesConnector.instance.createMovie | ||
| .ref( | ||
| genre: 'Action', | ||
| title: 'The Matrix', | ||
| releaseYear: 1999, | ||
| rating: 4.5, | ||
| ) | ||
| .execute(); | ||
|
|
||
| await MoviesConnector.instance.listMovies.ref().execute(); | ||
|
|
||
| await Future.delayed(const Duration(seconds: 1)); |
Member
There was a problem hiding this comment.
Worth using Completers for this type of test: https://github.com/firebase/flutterfire/blob/spm-core-2/tests/integration_test/firebase_storage/task_e2e.dart#L136-L163
It means you don't have to use Future.delayed which could be flakey
| group( | ||
| '$FirebaseDataConnect.instance listen', | ||
| () { | ||
| // ignore: unused_local_variable |
Member
There was a problem hiding this comment.
I don't think this is still needed if it is used?
| group( | ||
| '$FirebaseDataConnect.instance query', | ||
| () { | ||
| // ignore: unused_local_variable |
| # The following line prevents the package from being accidentally published to | ||
| # pub.dev using `flutter pub publish`. This is preferred for private packages. | ||
| publish_to: 'none' # Remove this line if you wish to publish to pub.dev | ||
| description: 'A new Flutter project.' |
Member
There was a problem hiding this comment.
Suggested change
| description: 'A new Flutter project.' | |
| description: 'Firebase Data Connect example app' |
| late MockFirebaseAuth mockAuth; | ||
| late MockFirebaseAppCheck mockAppCheck; | ||
| late MockConnectorConfig mockConnectorConfig; | ||
| // ignore: unused_local_variable |
Member
There was a problem hiding this comment.
Suggested change
| // ignore: unused_local_variable |
I guess this can also be removed
Salakar
approved these changes
Sep 12, 2024
Salakar
reviewed
Sep 12, 2024
| DeleteMovieMovieDelete.fromJson(Map<String, dynamic> json) | ||
| : id = json['id'] {} | ||
|
|
||
| // TODO(mtewani): Fix up to create a map on the fly |
Contributor
There was a problem hiding this comment.
Are these todos relevant btw?
Contributor
Author
There was a problem hiding this comment.
These todos are generated when using the VSCode extension, so nothing we can directly do in this repository.
russellwheatley
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
#13063
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?