fix for build windows - #646
Merged
Merged
Conversation
a-maurice
requested changes
Mar 9, 2023
a-maurice
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution. In general it seems fine, just one minor thing
| firebase::App::RegisterLibrary(library.c_str(), | ||
| version.c_str(), | ||
| nullptr); | ||
| version.c_str()); |
Contributor
There was a problem hiding this comment.
This was a recent change to the Firebase C++ SDK, so you might just be out of date on that. https://github.com/firebase/firebase-cpp-sdk/pull/1217/files#diff-fa379ca24a0012efe3cc69026f1be97dcba3f5883f45c26cb5314f4b2c3190ee
Contributor
Author
There was a problem hiding this comment.
I see, we need to update subrepo too
But then, are there anyway we could also update subrepo along with the main repo automatically?
a-maurice
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
firebase::App::RegisterLibrarywhich only have 2 parameter for windows platformMore details in #557
Testing
Run
python ./scripts/build_scripts/build_zips.py --use_boringssl=false --platform=windowsand got zip and dll files result properly without errorType of Change
Place an
xthe applicable box:ps This is cmakesettings.json I need to explicitly configure in my machine
{ "configurations": [ { "name": "x64-Debug", "generator": "Ninja", "configurationType": "Debug", "inheritEnvironments": [ "msvc_x64_x64" ], "buildRoot": "${projectDir}\\out\\windows_unity\\${name}", "installRoot": "${projectDir}\\out\\install\\${name}", "cmakeCommandArgs": "", "buildCommandArgs": "", "ctestCommandArgs": "", "variables": [ { "name": "UNITY_ROOT_DIR", "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/", "type": "STRING" }, { "name": "MONO_EXE", "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe", "type": "STRING" }, { "name": "MONO_CSHARP_BUILD_EXE", "value": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/MSBuild/Current/Bin/MSBuild.exe", "type": "STRING" }, { "name": "UNITY_MONO_EXE", "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe", "type": "STRING" }, { "name": "UNITY_CSHARP_BUILD_EXE", "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/xbuild.bat", "type": "STRING" }, { "name": "ZLIB_INCLUDE_DIR", "value": "C:/Program Files (x86)/GnuWin32/include/", "type": "STRING" }, { "name": "ZLIB_LIBRARY", "value": "C:/Program Files (x86)/GnuWin32/lib/zlib.lib", "type": "STRING" } ] } ] }