Skip to content

fix for build windows - #646

Merged
a-maurice merged 1 commit into
firebase:mainfrom
Thaina:main
Mar 16, 2023
Merged

fix for build windows#646
a-maurice merged 1 commit into
firebase:mainfrom
Thaina:main

Conversation

@Thaina

@Thaina Thaina commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

  • Explicitly disable boringssl to use openssl
  • Add netstandard reference to make build success
  • Fix the call to firebase::App::RegisterLibrary which only have 2 parameter for windows platform

More details in #557


Testing

Describe how you've tested these changes.

Run python ./scripts/build_scripts/build_zips.py --use_boringssl=false --platform=windows and got zip and dll files result properly without error


Type of Change

Place an x the applicable box:

  • [ x ] Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • [ x ] Other, such as a build process or documentation change.

ps This is cmakesettings.json I need to explicitly configure in my machine

{
  "configurations": [
    {
      "name": "x64-Debug",
      "generator": "Ninja",
      "configurationType": "Debug",
      "inheritEnvironments": [ "msvc_x64_x64" ],
      "buildRoot": "${projectDir}\\out\\windows_unity\\${name}",
      "installRoot": "${projectDir}\\out\\install\\${name}",
      "cmakeCommandArgs": "",
      "buildCommandArgs": "",
      "ctestCommandArgs": "",
      "variables": [
        {
          "name": "UNITY_ROOT_DIR",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/",
          "type": "STRING"
        },
        {
          "name": "MONO_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe",
          "type": "STRING"
        },
        {
          "name": "MONO_CSHARP_BUILD_EXE",
          "value": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/MSBuild/Current/Bin/MSBuild.exe",
          "type": "STRING"
        },
        {
          "name": "UNITY_MONO_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/mono.exe",
          "type": "STRING"
        },
        {
          "name": "UNITY_CSHARP_BUILD_EXE",
          "value": "C:/Program Files/Unity/Hub/Editor/2022.2.9f1/Editor/Data/MonoBleedingEdge/bin/xbuild.bat",
          "type": "STRING"
        },
        {
          "name": "ZLIB_INCLUDE_DIR",
          "value": "C:/Program Files (x86)/GnuWin32/include/",
          "type": "STRING"
        },
        {
          "name": "ZLIB_LIBRARY",
          "value": "C:/Program Files (x86)/GnuWin32/lib/zlib.lib",
          "type": "STRING"
        }
      ]
    }
  ]
}

@a-maurice a-maurice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. In general it seems fine, just one minor thing

Comment thread app/src/swig/app.i Outdated
firebase::App::RegisterLibrary(library.c_str(),
version.c_str(),
nullptr);
version.c_str());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thaina Thaina Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, we need to update subrepo too

But then, are there anyway we could also update subrepo along with the main repo automatically?

@a-maurice
a-maurice merged commit 1d3b6cc into firebase:main Mar 16, 2023
@firebase firebase locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants