Skip to content

chore: update Functions backend dependencies and upgrade to V2 API - #1499

Merged
AustinBenoit merged 3 commits into
mainfrom
security-audit/functions-backend
Aug 11, 2026
Merged

chore: update Functions backend dependencies and upgrade to V2 API#1499
AustinBenoit merged 3 commits into
mainfrom
security-audit/functions-backend

Conversation

@inlined

@inlined inlined commented Jul 30, 2026

Copy link
Copy Markdown
Member

Security Audit & Remediation: functions-backend

A. Previous CVEs

B. Changes Made

  • Updated firebase-admin to ^14.2.0 and firebase-functions to ^7.3.2.
  • Upgraded Cloud Functions definitions in the testapp backend and sample backend to use the Firebase Functions V2 API.
  • Added overrides in package.json for uuid (^11.1.1) and brace-expansion (^5.0.8) to resolve transitive CVEs.
  • Generated and added missing package-lock.json files.
  • Added node_modules/ to root .gitignore.
  • Removes a production dependency and is safe because it's running the full software suite that would run in docker in Cloud Functions.

C. Remaining CVEs

  • None

D. Introduced CVEs

  • None

E. Testing Strategy

  • Ran local syntax check (node -c index.js) successfully on both files.
  • Ran npm audit in both package directories showing 0 vulnerabilities.

Release Notes

relnote: "chore: update functions backend dependencies to resolve security vulnerabilities and upgrade callable functions to V2 API"

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Firebase Cloud Functions to the v2 API, upgrades dependencies, and targets Node.js 22. Feedback is provided regarding potential runtime TypeErrors when accessing properties on request.data if the client sends no payload; using optional chaining is recommended to handle these cases safely.

Comment thread functions/testapp/Assets/Firebase/Sample/Functions/.functions/functions/index.js Outdated
Comment thread functions/testapp/functions/functions/index.js Outdated
@inlined
inlined force-pushed the security-audit/functions-backend branch from 3136954 to f7bf8da Compare July 30, 2026 00:38
@inlined
inlined requested a review from AustinBenoit July 30, 2026 01:11
@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Aug 5, 2026
@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 729e093
Last updated: Wed Aug 5 18:42 PDT 2026
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [2021] [1/2 Build OS(s): macos] [1/2 Platform(s): 15] [1/6 Test Device(s): tvOS]

@AustinBenoit
AustinBenoit merged commit f45f826 into main Aug 11, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests: failed This PR's integration tests failed. tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants