Remove Mutation tombstones - #1354
Merged
Merged
Conversation
schmidt-sebastian
requested review from
gsoltis,
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
November 3, 2018 00:03
schmidt-sebastian
force-pushed
the
mrschmidt-removetombstone
branch
from
November 3, 2018 00:09
86a218a to
2956645
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-removetombstone
branch
from
November 3, 2018 00:24
2956645 to
2146dc9
Compare
wilhuff
approved these changes
Nov 5, 2018
|
|
||
| /** Converts this batch into a tombstone */ | ||
| toTombstone(): MutationBatch { | ||
| return new MutationBatch(this.batchId, this.localWriteTime, []); |
Contributor
There was a problem hiding this comment.
Could we restore the assertion that the mutations array is non-empty in the constructor?
This was referenced Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If my understanding is correct, we no longer remove mutation batches from any place but the front of the queue. This PR removes the code that handles this removal.