Skip to content

Fix RC db flags - #8897

Merged
karenyz merged 2 commits into
masterfrom
kz-rc-db-fix
Nov 2, 2021
Merged

Fix RC db flags#8897
karenyz merged 2 commits into
masterfrom
kz-rc-db-fix

Conversation

@karenyz

@karenyz karenyz commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

Fixes #8807

@google-oss-bot

google-oss-bot commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator

Coverage Report

Affected SDKs

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    SDK overall coverage changed from 78.96% (eb6ae96) to 78.97% (9ddf4b4) by +0.01%.

    Filename Base (eb6ae96) Head (9ddf4b4) Diff
    RCNConfigDBManager.m 75.91% 75.95% +0.04%

Test Logs

@karenyz
karenyz requested a review from paulb777 November 1, 2021 17:43

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please add a release note for 8.10.0

How did you verify/test?

@karenyz

karenyz commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

Similar to what was mentioned in the github issue, tested on device and saw the auth error if the phone was locked during RC DB loading:

Screen Shot 2021-11-02 at 4 15 24 PM

No longer saw the error after updating the flag

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenyz
karenyz merged commit 217a348 into master Nov 2, 2021
@karenyz
karenyz deleted the kz-rc-db-fix branch November 2, 2021 23:54
@firebase firebase locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote Config doesn't work if the device is locked (due to File Protection settings)

3 participants