Skip to content

Release 7.1.0 cherry picks - #6917

Merged
maksymmalyhin merged 4 commits into
release-7.1from
mm/7.1.0-gdt-gul
Nov 6, 2020
Merged

Release 7.1.0 cherry picks#6917
maksymmalyhin merged 4 commits into
release-7.1from
mm/7.1.0-gdt-gul

Conversation

@maksymmalyhin

Copy link
Copy Markdown
Contributor

mikeger and others added 2 commits November 6, 2020 10:18
…s are called (#6863)

* Fix crash on iOS 14 when multiple completion methods are called

* Fixed lint

* Addressed the PR comments & implemented unit tests

* Reverted auto-extracted method

* Re-organized tests

* Added completion handler for FIRAuth
@google-cla

google-cla Bot commented Nov 6, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@maksymmalyhin

Copy link
Copy Markdown
Contributor Author

@mikeger Could you please provide your consent following the instructions from the comment.

@mikeger

mikeger commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@google-cla google-cla Bot added cla: yes and removed cla: no labels Nov 6, 2020

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CI failures are expected on release branch because latest Analytics isn't available in GHA

@morganchen12 morganchen12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs LGTM

@maksymmalyhin
maksymmalyhin merged commit 2385785 into release-7.1 Nov 6, 2020
@maksymmalyhin
maksymmalyhin deleted the mm/7.1.0-gdt-gul branch November 6, 2020 19:55
maksymmalyhin added a commit that referenced this pull request Nov 11, 2020
* Update versions for Release 7.1.0

* 7.1.0 update version of close source podspecs

* Release 7.1.0 cherry picks (#6917)

* FCM: Fix crash on iOS 14 when multiple app delegate completion methods are called (#6863)

* Fix crash on iOS 14 when multiple completion methods are called

* Fixed lint

* Addressed the PR comments & implemented unit tests

* Reverted auto-extracted method

* Re-organized tests

* Added completion handler for FIRAuth

* Manifest: GDT 8.0.1

* Update Changelogs for 7.1.0 (#6913)

* Changelogs

Co-authored-by: Mike Gerasimenko <github@gerasimenko.me>
Co-authored-by: Paul Beusterien <paulbeusterien@google.com>

* Bump GDT podspec version to 8.0.1

* 7.1.0 SPM Analytics (#6933)

* Carthage update 7.1.0 (#6943)

Co-authored-by: Mike Gerasimenko <github@gerasimenko.me>
Co-authored-by: Paul Beusterien <paulbeusterien@google.com>
@firebase firebase locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants