Add a completion handler to FIRExperimentController's updateExperimentsWithServiceOrigin: method - #4897
Merged
Merged
Conversation
… the user property controller-- it doesn't do anything in the background
paulb777
reviewed
Feb 15, 2020
morganchen12
approved these changes
Feb 15, 2020
morganchen12
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one nit; please wait for one other approver before merging.
paulb777
approved these changes
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion handler takes a nullable error parameter.
Internal bug ID 141921647.
Partial fix for #3687.