Skip to content

Initialize and pass GDTCoreTransport to FIRCLSReportManager - #4802

Merged
jasonhu-g merged 2 commits into
crashlytics-firelogfrom
jasonhu-passGoogleTransportIntoReportManager
Feb 3, 2020
Merged

Initialize and pass GDTCoreTransport to FIRCLSReportManager#4802
jasonhu-g merged 2 commits into
crashlytics-firelogfrom
jasonhu-passGoogleTransportIntoReportManager

Conversation

@jasonhu-g

@jasonhu-g jasonhu-g commented Feb 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Initialize and pass GDTCoreTransport to FIRCLSReportManager
  2. Create mock class for GDTCoreTransport (for future unit tests)
  3. Clean up initializers in FIRCLSMockReportManager

@jasonhu-g
jasonhu-g requested a review from samedson February 3, 2020 15:57
samedson
samedson reviewed Feb 3, 2020
View reviewed changes
Comment thread Crashlytics/Crashlytics/FIRCrashlytics.m Outdated
samedson
samedson approved these changes Feb 3, 2020
View reviewed changes

@samedson samedson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing

@jasonhu-g
jasonhu-g merged commit e35f930 into crashlytics-firelog Feb 3, 2020
@jasonhu-g
jasonhu-g deleted the jasonhu-passGoogleTransportIntoReportManager branch February 3, 2020 16:31
@firebase firebase locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samedson samedson samedson approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonhu-g @samedson @googlebot