Update Crashlytics CHANGELOG for beta.3 out of band release - #4788
Merged
Conversation
cbonnie
reviewed
Jan 31, 2020
cbonnie
suggested changes
Jan 31, 2020
| # v4.0.0-beta.3 | ||
|
|
||
| - [fixed] Fixed symbol collisions with the legacy Fabric Crashlytics SDK and added a warning not to include both (#4753, #4755) | ||
| - [fixed] Fixed an import declaration when installing using CocoaPods with the `generate_multiple_pod_projects` flag set to true (#4786) |
There was a problem hiding this comment.
Please change to:
"Fixed an import declaration for installing Crashlytics using CocoaPods. Previously, the declaration caused a compile error when you installed with the generate_multiple_pods_project flag set to true"
I'm not sure whether importing <FirebaseCore/FIRApp.h> is the same as "installing Crashlytics" so please revise if necessary.
Contributor
Author
There was a problem hiding this comment.
Revision makes sense!
cbonnie
approved these changes
Jan 31, 2020
| # v4.0.0-beta.3 | ||
|
|
||
| - [fixed] Fixed an import declaration when installing using CocoaPods with the `generate_multiple_pod_projects` flag set to true (#4786) | ||
| - [fixed] Fixed an import declaration for installing Crashlytics using CocoaPods. Previously, the declaration caused a compile error when you installed using CocoaPods with the `generate_multiple_pods_project` flag set to true (#4786) |
There was a problem hiding this comment.
Please get rid of "using CocoaPods" :P So:
Fixed an import declaration for installing Crashlytics using CocoaPods. Previously, the declaration caused a compile error when you installed with the generate_multiple_pods_project flag set to true (#4786)
ryanwilson
pushed a commit
that referenced
this pull request
Jan 31, 2020
ryanwilson
added a commit
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crashlytics is doing an out of band release for beta.3 to fix #4786
Later, I will open a PR for the following changes that will be released with the other Firebase SDKs in a following release:
v4.0.0-beta.4