Split auth api tests into multiple cases - #2399
Merged
Merged
Conversation
Yue-Wang-Google
approved these changes
Feb 15, 2019
Yue-Wang-Google
left a comment
Contributor
There was a problem hiding this comment.
LTGM. just a few nits.
| #import "FIRAuthApiTestsBase.h" | ||
|
|
||
| @interface AnonymousAuthTests : FIRAuthApiTestsBase | ||
|
|
Contributor
There was a problem hiding this comment.
remove the new line here.
Contributor
Author
There was a problem hiding this comment.
You mean line 22 right? I prefer keep it since it's makes the class structure clearer
Contributor
There was a problem hiding this comment.
Removing the line for a simple class with 0 method is more common among Google3 code. see http://google.github.io/styleguide/objcguide.html#prefixes
It's ok if you dont remove, because I don't care much about it.
| @"Invalid assertion format. 3 dot separated segments required."; | ||
|
|
||
| @interface CustomAuthTests : FIRAuthApiTestsBase | ||
|
|
Contributor
There was a problem hiding this comment.
remove new line. same for other files
bstpierr
added a commit
that referenced
this pull request
Feb 19, 2019
* master: E2e tests split (#2401) Split auth api tests into multiple cases (#2399) Add a ToString function to create human-readable debug descriptions (#2384) Split Auth unit tests (#2396) Create umbrella header for FIAM (#2392) Deprecate setMinimumSessionInterval (#2305) Forbid queries endAt an uncommitted server timestamp. (#2382) update changelog for release (#2383) Fix FIAM Travic CI issues (#2380) Remove swift sample for Auth (#2371) C++ migration: port `FSTTransaction` (#2362) Fix a bug where unlinking emailpassword doesn’t remove provider data (#2370) Fix a bug where sign in with Game Center doesn’t return additional user info (#2368) Firebase In-app messaging callbacks (#2354) Fix a bug where sign in with email link always return isNewUser as false (#2363) C++ migration: eliminate `FSTRemoteStore` (#2338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.