Firebase In-app messaging callbacks - #2354
Merged
Merged
Conversation
…refactor + downstream changes
…g through to app-side delegate from default display executor
…a framework anymore
paulb777
requested changes
Feb 6, 2019
paulb777
left a comment
Member
There was a problem hiding this comment.
Run scripts/style.sh and get Travis green - https://travis-ci.org/firebase/firebase-ios-sdk/jobs/489332949
paulb777
reviewed
Feb 7, 2019
christibbs
requested review from
morganchen12
and removed request for
ryanwilson
February 8, 2019 20:41
Contributor
Author
|
Addressed @paulb777 's changes. |
paulb777
approved these changes
Feb 8, 2019
bstpierr
added a commit
that referenced
this pull request
Feb 19, 2019
* master: E2e tests split (#2401) Split auth api tests into multiple cases (#2399) Add a ToString function to create human-readable debug descriptions (#2384) Split Auth unit tests (#2396) Create umbrella header for FIAM (#2392) Deprecate setMinimumSessionInterval (#2305) Forbid queries endAt an uncommitted server timestamp. (#2382) update changelog for release (#2383) Fix FIAM Travic CI issues (#2380) Remove swift sample for Auth (#2371) C++ migration: port `FSTTransaction` (#2362) Fix a bug where unlinking emailpassword doesn’t remove provider data (#2370) Fix a bug where sign in with Game Center doesn’t return additional user info (#2368) Firebase In-app messaging callbacks (#2354) Fix a bug where sign in with email link always return isNewUser as false (#2363) C++ migration: eliminate `FSTRemoteStore` (#2338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality for apps to receive message lifecycle callbacks by registering a delegate that implements a fleshed out
FIRInAppMessagingDisplayDelegate:Fleshed out
FIRInAppMessagingDisplayDelegateis now:- (void)messageClicked:(FIRInAppMessagingDisplayMessage *)inAppMessage- (void)messageDismissed:(FIRInAppMessagingDisplayMessage *)inAppMessage dismissType:(FIRInAppMessagingDismissType)dismissType- (void)impressionDetectedForMessage:(FIRInAppMessagingDisplayMessage *)inAppMessage- (void)displayErrorForMessage:(FIRInAppMessagingDisplayMessage *)inAppMessage error:(NSError *)errorTODO: Add unit tests to ensure delegate callbacks are fired.