Skip to content

Add support of Game Center sign in - #2127

Merged
renkelvin merged 5 commits into
masterfrom
game-center
Dec 1, 2018
Merged

Add support of Game Center sign in#2127
renkelvin merged 5 commits into
masterfrom
game-center

Conversation

@renkelvin

Copy link
Copy Markdown
Contributor

No description provided.

@paulb777
paulb777 requested a review from ryanwilson November 28, 2018 19:33

@ryanwilson ryanwilson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just small nits, otherwise LGTM.

Comment thread Example/Auth/Tests/FIRSignInWithGameCenterTests.m Outdated
Comment thread Firebase/Auth/Source/FIRAuthErrorUtils.m Outdated
Comment thread Firebase/Auth/Source/NSData+FIRBase64.h Outdated
Comment thread Firebase/Auth/Source/Public/FIRAuthErrors.h
Comment thread Firebase/Auth/Source/Public/FIRGameCenterAuthProvider.h Outdated
Comment thread Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.h Outdated
Comment thread Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.h Outdated
Comment thread Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.m
Comment thread Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterResponse.h Outdated
Comment thread Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterResponse.m Outdated
@renkelvin
renkelvin merged commit 6632255 into master Dec 1, 2018
@renkelvin
renkelvin deleted the game-center branch December 1, 2018 01:30
bstpierr added a commit that referenced this pull request Dec 6, 2018
* master: (26 commits)
  Functions Interop (#2113)
  Add a travis cron job for CocoaPod symbol collision testing (#2154)
  Save schema version on downgrade, add test to verify (#2153)
  Silence Storage Unit Test `nil` warning. (#2150)
  Update versions for Release 5.14.0 (#2145)
  gRPC: fix cases where gRPC call could be finished twice (#2146)
  Fix Swizzler test warnings (#2144)
  Update Auth CHANGELOG.md (#2128)
  Make fuzz tests optional until they pass (#2143)
  Add support of Game Center sign in (#2127)
  Add test for deprecated FDLURLComponents init API. (#2133)
  fix a typo in integration test (#2131)
  Make fuzzing less verbose to avoid exceeding Travis log limit (#2126)
  Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119)
  Carthage instructions for new gRPCCertificates.bundle location (#2132)
  Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130)
  Avoid using default FIROptions directly. (#2124)
  Changelog entry for LRU GC (#2122)
  Revert "Add Firebase Source to Header Search Path" (#2123)
  Custom fdl domain (#2121)
  ...
@renkelvin
renkelvin restored the game-center branch December 17, 2018 22:58
@renkelvin
renkelvin deleted the game-center branch February 5, 2019 22:50
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants