Lock reads and writes to session map - #1970
Merged
Merged
Conversation
Member
|
Any particular reason for |
Contributor
Author
|
I wanted an explicit object to lock/unlock on rather than an implicit lock associated with a class instance or something. This isn't a hugely important decision, and I can rewrite to use |
morganchen12
force-pushed
the
urlsession
branch
from
October 19, 2018 21:14
edf1c4c to
b86e452
Compare
Member
|
I think this may be causing a deadlock based on Travis. Please try to catch this locally if you can to make sure we aren't causing a deadlock anywhere. Using |
morganchen12
force-pushed
the
urlsession
branch
from
October 22, 2018 17:31
b86e452 to
1dea38c
Compare
Contributor
Author
|
Fixed deadlock and passed travis. |
ryanwilson
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially fix #1964.
TAP runs over at cr/217930814.