SessionToken persistence implementation - #13684
Merged
Merged
Conversation
tom-andersen
marked this pull request as ready for review
September 24, 2024 14:47
wu-hui
approved these changes
Sep 24, 2024
wu-hui
left a comment
Contributor
There was a problem hiding this comment.
Some minor nits, please do fix them before merging.
LGTM in the meantime.
paulb777
reviewed
Sep 25, 2024
| @@ -1,5 +1,6 @@ | |||
| # Unreleased | |||
| - [changed] Improve efficiency of memory persistence when processing a large number of writes. (#13572) | |||
| - [changed] Prepare Firestore cache to support session token. | |||
Member
There was a problem hiding this comment.
This change missed yesterday's code freeze. Please move to unreleased.
tom-andersen
added a commit
that referenced
this pull request
Sep 25, 2024
This reverts commit 2893101.
paulb777
pushed a commit
that referenced
this pull request
Sep 25, 2024
tom-andersen
added a commit
that referenced
this pull request
Oct 3, 2024
tom-andersen
added a commit
that referenced
this pull request
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal change to Firestore.
Prepare persistence of session token. This will be used in future work to support database name resuse.
This was reverted to delay release: #13719