Crashlytics add warning about including new and old SDK - #4755
Merged
Conversation
ryanwilson
approved these changes
Jan 28, 2020
ryanwilson
left a comment
Member
There was a problem hiding this comment.
One thing we may want to add: something about "The Crashlytics SDK has been deprecated and FirebaseCrashlytics should be used instead."?
Contributor
Author
|
@ryanwilson gonna leave that statement off for now. We're still treating the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including multiple crash reporters tends to cause issues with registering exception handlers. Making this a warning so that we don't break builds. Putting in the public header so that zip install / Carthage users get the same warning.
Related to #4753