Skip to content

use native android call with app as parameter - #390

Merged
vimanyu merged 4 commits into
mainfrom
bugfix/android-remote-config-specific-app
Apr 28, 2021
Merged

use native android call with app as parameter#390
vimanyu merged 4 commits into
mainfrom
bugfix/android-remote-config-specific-app

Conversation

@vimanyu

@vimanyu vimanyu commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

For Remote Config, use the method that allows passing in a custom app,
In the Android SDK, we callgetInstance(app) instead of getInstance().
Fixes: firebase/quickstart-unity#991

@vimanyu
vimanyu requested a review from cynthiajoan April 23, 2021 01:36
@vimanyu vimanyu self-assigned this Apr 23, 2021
@google-cla google-cla Bot added the cla: yes label Apr 23, 2021
cynthiajoan
cynthiajoan previously approved these changes Apr 23, 2021
@vimanyu vimanyu added the tests-requested: quick Trigger a quick set of integration tests. label Apr 23, 2021
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 23, 2021
@github-actions

github-actions Bot commented Apr 23, 2021

Copy link
Copy Markdown

✅  Integration test succeeded!

Requested by @vimanyu on commit 12c58cf
Last updated: Fri Apr 23 13:27:48 PDT 2021
View integration test results

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Apr 23, 2021
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 23, 2021
Comment thread release_build_files/readme.md Outdated
@vimanyu
vimanyu merged commit 7ebd34a into main Apr 28, 2021
@vimanyu
vimanyu deleted the bugfix/android-remote-config-specific-app branch April 28, 2021 18:11
@firebase firebase locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] RemoteConfig ignores FirebaseApp on Android

2 participants