Skip to content

Firestore: Fix global refs exhaustion issue in Android #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dconeybe merged 5 commits into from
Jun 30, 2023
Merged

Firestore: Fix global refs exhaustion issue in Android #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db1866
Fix the Android global refs exhaustion issue by using ArenaRef instea…
dconeybe Jun 27, 2023
6f44f92
release_build_files/readme.md: update PR number
dconeybe Jun 27, 2023
a742e67
Merge remote-tracking branch 'origin/main' into ArenaRef2
dconeybe Jun 30, 2023
9d66680
update comments as suggested by code reviewer
dconeybe Jun 30, 2023
b640bdd
Merge branch 'main' into dconeybe/ArenaRef2
dconeybe Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firestore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ set(android_SRCS
src/jni/array.h
src/jni/array_list.cc
src/jni/array_list.h
src/jni/arena_ref.cc
src/jni/arena_ref.h
src/jni/boolean.cc
src/jni/boolean.h
src/jni/call_traits.h
Expand Down
1 change: 1 addition & 0 deletions firestore/integration_test_internal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ set(FIREBASE_INTEGRATION_TEST_PORTABLE_TEST_SRCS

# These sources contain the actual tests that run on Android only.
set(FIREBASE_INTEGRATION_TEST_ANDROID_TEST_SRCS
src/android/arena_ref_android_test.cc
src/android/field_path_portable_test.cc
src/android/firestore_integration_test_android_test.cc
src/android/geo_point_android_test.cc
Expand Down
Loading