Skip to content

fix(firestore): added missing 'ReadWriteTransactionOptions' export - #1875

Merged
lahirumaramba merged 7 commits into
firebase:masterfrom
naodya:fix/missing-export-read-write-transaction-option
Oct 28, 2022
Merged

fix(firestore): added missing 'ReadWriteTransactionOptions' export#1875
lahirumaramba merged 7 commits into
firebase:masterfrom
naodya:fix/missing-export-read-write-transaction-option

Conversation

@naodya

@naodya naodya commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

ReadWriteTransactionOptions is not exported from firebase-admin/firestore however available in @google-cloud/firestore

@lahirumaramba
lahirumaramba self-requested a review October 17, 2022 21:29
@lahirumaramba

Copy link
Copy Markdown
Member

Hi @naodya, Thank you for your contribution! Could you run npm run api-extractor:local and add the new changes to the PR to fix the failing CIs, please?

@naodya

naodya commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

Hi @naodya, Thank you for your contribution! Could you run npm run api-extractor:local and add the new changes to the PR to fix the failing CIs, please?

@lahirumaramba Done!

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@lahirumaramba
lahirumaramba merged commit f596f2c into firebase:master Oct 28, 2022
@lahirumaramba lahirumaramba changed the title fix(firestore): added missing 'ReadWriteTransactionOptions' export (#1874) fix(firestore): added missing 'ReadWriteTransactionOptions' export Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants