Skip to content

feat(auth): MFA Support for GoLang createUser, updateUser - #511

Merged
pragatimodi merged 8 commits into
firebase:devfrom
pragatimodi:master
Nov 9, 2022
Merged

feat(auth): MFA Support for GoLang createUser, updateUser#511
pragatimodi merged 8 commits into
firebase:devfrom
pragatimodi:master

Conversation

@pragatimodi

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt_test.go
Comment thread auth/user_mgt_test.go Outdated
Comment thread auth/user_mgt_test.go
@pragatimodi
pragatimodi changed the base branch from master to dev October 4, 2022 21:01
@pragatimodi
pragatimodi requested a review from prameshj October 5, 2022 23:50

@prameshj prameshj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for create and update user. Once that's done and the comments here are addressed, feel free to get review from @lahirumaramba and submit. Thanks!

Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt.go Outdated
Comment thread auth/user_mgt_test.go Outdated
Comment thread auth/user_mgt.go Outdated
@lahirumaramba lahirumaramba changed the title MFA Support for GoLang createUser, updateUser feat(auth): MFA Support for GoLang createUser, updateUser Oct 28, 2022

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Comment thread auth/user_mgt.go
Comment thread auth/user_mgt.go
@lahirumaramba

Copy link
Copy Markdown
Member

Adding @kevinthecheung to review the reference doc changes. Thank you!

@brokeyourbike

Copy link
Copy Markdown
Contributor

Hi @lahirumaramba @kevinthecheung , when do you think this can be merged?

@pragatimodi
pragatimodi force-pushed the master branch 2 times, most recently from 23a1f17 to 1f84f17 Compare November 9, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants