Skip to content

fix(auth): Removed MultiFactoryID public type - #431

Merged
hiranya911 merged 1 commit into
devfrom
hkj-mfa
Mar 31, 2021
Merged

fix(auth): Removed MultiFactoryID public type#431
hiranya911 merged 1 commit into
devfrom
hkj-mfa

Conversation

@hiranya911

Copy link
Copy Markdown
Contributor

Adds to the changes made in #422. This PR:

  • Removed MultiFactorID type and Phone constant value.
  • Adding a check to gracefully handle unsupported auth factors.

Part of go/firebase-mfa-go

@hiranya911

Copy link
Copy Markdown
Contributor Author

@jasperkuperus FYI

@jasperkuperus

jasperkuperus commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Looks good. Any idea when this will be released?

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hiranya! LGTM!

@hiranya911
hiranya911 merged commit 11d5daa into dev Mar 31, 2021
@hiranya911
hiranya911 deleted the hkj-mfa branch March 31, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants