add fcmOptions in WebpushConfig - #185
Merged
Merged
Conversation
Contributor
Author
|
GO 1.7 and 1.8 is no longer supported by lint : golang/lint#420 Maybe we have to disable it on travis for older version ? |
Contributor
Author
|
Formatting has changed on go 1.11 check an exemple here : golang/go@542ea5a So formatting has changed
this is why the build failed |
Contributor
Author
|
Maybe we can just gofmt ( ./.travis.gofmt.sh) for go >= 1.11 due to incompatible changes |
Contributor
|
We currently don't test on go 1.11 so I think we can ignore the gofmt issue for now. |
hiranya911
suggested changes
Nov 13, 2018
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Thanks @chemidy for the PR, and sorry for not replying earlier. A couple of changes pointed out for your attention.
hiranya911
approved these changes
Nov 13, 2018
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @chemidy :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new option in webpushconfig
#182