Skip to content

extend dataRequestErrorToStatus testing #996

Merged
gupadhyaya merged 1 commit into
mainfrom
sevey/table-test
Jun 9, 2023
Merged

extend dataRequestErrorToStatus testing #996
gupadhyaya merged 1 commit into
mainfrom
sevey/table-test

Conversation

@MSevey

@MSevey MSevey commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Overview

Extend the unit testing to cover more test cases and turn into a table test as an example for future unit testing.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov

codecov Bot commented Jun 8, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (784a455) 54.90% compared to head (d8ee5b2) 54.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   54.90%   54.73%   -0.18%     
==========================================
  Files          60       60              
  Lines        6380     6380              
==========================================
- Hits         3503     3492      -11     
- Misses       2522     2533      +11     
  Partials      355      355              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MSevey MSevey requested a review from gupadhyaya June 8, 2023 14:14
Comment thread da/celestia/celestia_test.go
@gupadhyaya gupadhyaya enabled auto-merge June 9, 2023 16:07
@gupadhyaya gupadhyaya added this pull request to the merge queue Jun 9, 2023
Merged via the queue into main with commit 4674e78 Jun 9, 2023
@gupadhyaya gupadhyaya deleted the sevey/table-test branch June 9, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:enhancement T:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants