Skip to content

Adapting mempool for cometbft release#991

Merged
Ferret-san merged 3 commits into
diego/cometbftfrom
diego/cometbft-0.37.1-mempool
Jul 7, 2023
Merged

Adapting mempool for cometbft release#991
Ferret-san merged 3 commits into
diego/cometbftfrom
diego/cometbft-0.37.1-mempool

Conversation

@Ferret-san

@Ferret-san Ferret-san commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

This PR addresses the following comments from @tzdybal on #793

Consider re-importing latest version of mempool from cometbft (as separate, follow-up PR).

This PR reimports the latest version of mempool from cometbft 0.37.0

@codecov

codecov Bot commented Jun 7, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 86.20% and project coverage change: +0.13 🎉

Comparison is base (e40e5a9) 54.01% compared to head (a8b0ff0) 54.14%.

❗ Current head a8b0ff0 differs from pull request most recent head ca05435. Consider uploading reports for the commit ca05435 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##           diego/cometbft     #991      +/-   ##
==================================================
+ Coverage           54.01%   54.14%   +0.13%     
==================================================
  Files                  63       54       -9     
  Lines                6680     6076     -604     
==================================================
- Hits                 3608     3290     -318     
+ Misses               2682     2438     -244     
+ Partials              390      348      -42     
Impacted Files Coverage Δ
mempool/v1/mempool.go 85.47% <86.20%> (+3.10%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gupadhyaya gupadhyaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@tzdybal tzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Expected more changes lol.

@tzdybal tzdybal added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jun 27, 2023
@Ferret-san Ferret-san merged commit 6b452f2 into diego/cometbft Jul 7, 2023
@Ferret-san Ferret-san deleted the diego/cometbft-0.37.1-mempool branch July 7, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants