da: replace go-cnc with celestia-openrpc#986
Merged
Merged
Conversation
306d0ed to
d65d449
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 55.86% 55.59% -0.28%
==========================================
Files 63 63
Lines 6759 6803 +44
==========================================
+ Hits 3776 3782 +6
- Misses 2573 2611 +38
Partials 410 410
☔ View full report in Codecov by Sentry. |
tuxcanfly
commented
Jun 14, 2023
Collaborator
Author
|
Blocked by celestiaorg/celestia-openrpc#10 |
tuxcanfly
commented
Jun 14, 2023
3f6fe75 to
dd224bb
Compare
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
c28d12e to
e9b75aa
Compare
tuxcanfly
commented
Jun 16, 2023
Collaborator
Author
|
Blocked by #1018 |
e9b75aa to
0343f9f
Compare
Collaborator
Author
|
Resolved #1018 so unblocked, requesting re-reviews. |
gupadhyaya
reviewed
Jun 20, 2023
gupadhyaya
reviewed
Jun 20, 2023
gupadhyaya
reviewed
Jun 20, 2023
Contributor
|
can you fix the failing tests? you can fetch your latest changes in the celestia-openrpc PR branch by using the latest commit. e.g., |
Wondertan
reviewed
Jun 21, 2023
Collaborator
Author
|
OK, will wait for celestiaorg/celestia-node#2376 celestiaorg/celestia-node#2367 to be merged first. |
MSevey
previously approved these changes
Jul 6, 2023
gupadhyaya
previously approved these changes
Jul 6, 2023
nashqueue
previously approved these changes
Jul 6, 2023
MSevey
previously approved these changes
Jul 6, 2023
2eb769e
gupadhyaya
approved these changes
Jul 6, 2023
nashqueue
approved these changes
Jul 6, 2023
gupadhyaya
pushed a commit
that referenced
this pull request
Jul 13, 2023
This PR replaces `go-cnc` with `celestia-openrpc` for the client. Fixes - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces
go-cncwithcelestia-openrpcfor the client. Fixes #979Checklist