Skip to content

Delete CODEOWNERS#971

Merged
MSevey merged 1 commit into
mainfrom
remove-codeowners
Jun 2, 2023
Merged

Delete CODEOWNERS#971
MSevey merged 1 commit into
mainfrom
remove-codeowners

Conversation

@MSevey

@MSevey MSevey commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Overview

As discussed in the retro, we are removing the CODEOWNERs file so that it doesn't conflict with the auto-review-request github action. I have also disabled the branch project rule for requiring codeowner approval.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey

MSevey commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

@smuu now that we are relying on the auto-request-reviewer workflow we are seeing errors

https://github.com/rollkit/rollkit/actions/runs/5157852504/jobs/9290802210?pr=971

@MSevey

MSevey commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

@smuu now that we are relying on the auto-request-reviewer workflow we are seeing errors

https://github.com/rollkit/rollkit/actions/runs/5157852504/jobs/9290802210?pr=971

looks like sysrex wasn't on the celestia team so not a contributor to this repo. I sent them an invite, so it should be fixed.

@MSevey MSevey added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jun 2, 2023
@codecov

codecov Bot commented Jun 2, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -1.82 ⚠️

Comparison is base (8b1f9b4) 56.17% compared to head (d88192a) 54.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   56.17%   54.36%   -1.82%     
==========================================
  Files          68       54      -14     
  Lines       10915     6032    -4883     
==========================================
- Hits         6131     3279    -2852     
+ Misses       3901     2404    -1497     
+ Partials      883      349     -534     

see 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MSevey MSevey merged commit f6c871c into main Jun 2, 2023
@MSevey MSevey deleted the remove-codeowners branch June 2, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants