Skip to content

Fix go.mod#970

Merged
gupadhyaya merged 3 commits into
mainfrom
diego/tidy-fix
Jun 6, 2023
Merged

Fix go.mod#970
gupadhyaya merged 3 commits into
mainfrom
diego/tidy-fix

Conversation

@Ferret-san

Copy link
Copy Markdown
Collaborator

Ever since some recent commits, attempting to run go mod tidy on Rollkit would results in the following error:

github.com/rollkit/rollkit/block imports
	github.com/cometbft/cometbft/abci/types imports
	github.com/cometbft/cometbft/crypto/secp256k1 imports
	github.com/btcsuite/btcd/btcec/v2/ecdsa tested by
	github.com/btcsuite/btcd/btcec/v2/ecdsa.test imports
	github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
	github.com/btcsuite/btcd v0.22.0-beta (/home/dferrer/go/pkg/mod/github.com/btcsuite/btcd@v0.22.0-beta/chaincfg/chainhash)
	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 (/home/dferrer/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.1)

This PR fixes the ambiguous import issue by upgrading github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 => v1.0.2

@codecov

codecov Bot commented Jun 2, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +1.63 🎉

Comparison is base (c4c0f78) 54.43% compared to head (db69d31) 56.06%.

❗ Current head db69d31 differs from pull request most recent head 27193d8. Consider uploading reports for the commit 27193d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   54.43%   56.06%   +1.63%     
==========================================
  Files          54       68      +14     
  Lines        6037    10915    +4878     
==========================================
+ Hits         3286     6120    +2834     
- Misses       2401     3912    +1511     
- Partials      350      883     +533     

see 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nashqueue nashqueue added T:dependencies T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jun 2, 2023
@gupadhyaya gupadhyaya added the T:bug Something isn't working label Jun 2, 2023
gupadhyaya
gupadhyaya previously approved these changes Jun 2, 2023
@MSevey

MSevey commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

part of this PR should be to un-comment the go mod tidy check

https://github.com/rollkit/rollkit/blob/main/.github/workflows/test.yml#L13

gupadhyaya
gupadhyaya previously approved these changes Jun 6, 2023
@gupadhyaya gupadhyaya self-requested a review June 6, 2023 15:07
@gupadhyaya gupadhyaya added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit bff724f Jun 6, 2023
@gupadhyaya gupadhyaya deleted the diego/tidy-fix branch June 6, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:bug Something isn't working T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants