change test.yml and makefile#968
Merged
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 56.17% 54.31% -1.87%
==========================================
Files 68 54 -14
Lines 10915 6032 -4883
==========================================
- Hits 6131 3276 -2855
+ Misses 3901 2408 -1493
+ Partials 883 348 -535 ☔ View full report in Codecov by Sentry. |
MSevey
previously approved these changes
May 31, 2023
MSevey
left a comment
Contributor
There was a problem hiding this comment.
LGTM, yes the failure is because it thinks the coverage went down.
I can admin merge this once other's approve and then update the required CI to not include the remove test step
Manav-Aggarwal
previously approved these changes
May 31, 2023
MSevey
reviewed
Jun 1, 2023
MSevey
approved these changes
Jun 2, 2023
nashqueue
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Code Coverage action appears to be broken, this is an attempt to fix it.
Fix inspired by https://github.com/celestiaorg/celestia-node/pull/2249/files
Checklist