Skip to content

change test.yml and makefile#968

Merged
MSevey merged 4 commits into
mainfrom
connor/fix-code-coverage
Jun 2, 2023
Merged

change test.yml and makefile#968
MSevey merged 4 commits into
mainfrom
connor/fix-code-coverage

Conversation

@S1nus

@S1nus S1nus commented May 31, 2023

Copy link
Copy Markdown
Contributor

Overview

The Code Coverage action appears to be broken, this is an attempt to fix it.

Fix inspired by https://github.com/celestiaorg/celestia-node/pull/2249/files

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@S1nus S1nus added C:ci Component: Continuous Integration github_actions Pull requests that update Github_actions code labels May 31, 2023
@S1nus S1nus marked this pull request as ready for review May 31, 2023 03:53
@S1nus S1nus added the T:bug Something isn't working label May 31, 2023
@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -1.87 ⚠️

Comparison is base (8b1f9b4) 56.17% compared to head (d509177) 54.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
- Coverage   56.17%   54.31%   -1.87%     
==========================================
  Files          68       54      -14     
  Lines       10915     6032    -4883     
==========================================
- Hits         6131     3276    -2855     
+ Misses       3901     2408    -1493     
+ Partials      883      348     -535     

see 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S1nus S1nus requested a review from MSevey May 31, 2023 05:06
MSevey
MSevey previously approved these changes May 31, 2023

@MSevey MSevey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yes the failure is because it thinks the coverage went down.
I can admin merge this once other's approve and then update the required CI to not include the remove test step

Manav-Aggarwal
Manav-Aggarwal previously approved these changes May 31, 2023
Comment thread .github/workflows/test.yml
@S1nus S1nus dismissed stale reviews from Manav-Aggarwal and MSevey via 7aa8baa June 1, 2023 17:16
@S1nus S1nus requested a review from Manav-Aggarwal June 2, 2023 15:18
@MSevey MSevey merged commit 30265e0 into main Jun 2, 2023
@MSevey MSevey deleted the connor/fix-code-coverage branch June 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:ci Component: Continuous Integration github_actions Pull requests that update Github_actions code T:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants