Skip to content

Remove header gossip from p2p module#964

Merged
gupadhyaya merged 2 commits into
mainfrom
manav/remove_header_gossip_from_p2p
May 30, 2023
Merged

Remove header gossip from p2p module#964
gupadhyaya merged 2 commits into
mainfrom
manav/remove_header_gossip_from_p2p

Conversation

@Manav-Aggarwal

@Manav-Aggarwal Manav-Aggarwal commented May 26, 2023

Copy link
Copy Markdown
Member

Overview

Closes: #965

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal added C:p2p p2p networking related T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:header labels May 26, 2023
@codecov

codecov Bot commented May 26, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (35d9071) 56.17% compared to head (ce26185) 56.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   56.17%   56.18%           
=======================================
  Files          68       68           
  Lines       10940    10925   -15     
=======================================
- Hits         6146     6138    -8     
+ Misses       3912     3903    -9     
- Partials      882      884    +2     
Impacted Files Coverage Δ
node/light.go 48.11% <ø> (-0.49%) ⬇️
p2p/client.go 60.28% <ø> (+0.19%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review May 26, 2023 21:32

@tzdybal tzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gupadhyaya gupadhyaya merged commit 6e7d3a6 into main May 30, 2023
@gupadhyaya gupadhyaya deleted the manav/remove_header_gossip_from_p2p branch May 30, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:header C:p2p p2p networking related T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove header gossip from P2P module

3 participants