fix header exchange init error#962
Merged
gupadhyaya merged 2 commits intoMay 31, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 56.21% 56.14% -0.07%
==========================================
Files 68 68
Lines 10925 10915 -10
==========================================
- Hits 6141 6128 -13
- Misses 3901 3903 +2
- Partials 883 884 +1
☔ View full report in Codecov by Sentry. |
tzdybal
approved these changes
May 29, 2023
nashqueue
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846
As per the discussion in #846, the aggregator node only need to initialize the store with genesis header, after that it only needs to broadcast the header without directly trying to append to store. The append is take care by the broadcast api which along with broadcasting also puts the header in the local append queue which then appends to the local store.