fix: handling ErrNamespaceNotFound for node v0.10.0

[distractedm1nd]

We have made a breaking change in node v0.10.0 regarding data requests. celestiaorg/celestia-node@62a0b97

Previously, a "data not found" meant both "the node failed to retrieve that data, please retry" as well as "the node retrieved the data successfully, but your namespace is not included in the data". We have split these errors, so now we have an ErrNamespaceNotFound which indicates a successful request for empty data.

I have no idea how to test rollkit so would love some help on getting that set up

[codecov]

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.89 ⚠️

Comparison is base (5766a91) 55.75% compared to head (f13c2bc) 54.87%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   55.75%   54.87%   -0.89%     
==========================================
  Files          59       60       +1     
  Lines        6268     6380     +112     
==========================================
+ Hits         3495     3501       +6     
- Misses       2418     2525     +107     
+ Partials      355      354       -1     

Impacted Files	Coverage Δ
da/celestia/celestia.go	7.14% <50.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gupadhyaya]

@distractedm1nd
tested without your PR using local-devnet v0.10.0 and got:

10:37PM ERR failed to retrieve block from DALC daHeight=14 errors="failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: getter/store: failed to retrieve shares by namespace: share: namespace not found in data" module=BlockManager

which disappeared after your fix. so, it is working.

however, we still have this error:

10:38PM ERR failed to retrieve block from DALC daHeight=27 errors="failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later; failed to retrieve block: current head local chain head: 26 is lower than requested height: 27 give header sync some time and retry later" module=BlockManager

while it is not preventing the block production, i think it is premature retrieve blocks error. any easy way to handle that?

[Wondertan]

@gupadhyaya, via API we now always allow for height head+1 to be requested before throwing this error.
@distractedm1nd. I think we should do the same for Gateway or ensure Gateway uses this API codepath

[gupadhyaya]

@gupadhyaya, via API we now always allow for height head+1 to be requested before throwing this error. @distractedm1nd. I think we should do the same for Gateway or ensure Gateway uses this API codepath

@Wondertan so where should we make the fix?

[Wondertan]

@gupadhyaya, in the node

[distractedm1nd]

@gupadhyaya Can you check celestiaorg/celestia-node#2291?

[gupadhyaya]

@gupadhyaya Can you check celestiaorg/celestia-node#2291?

thanks @distractedm1nd what is the easiest way to test this? I tried to build a local image and then run local-devnet with latest celestia-app and running into panics.

[gupadhyaya]

@Wondertan @distractedm1nd just tested rollkit using node 0.10.3 and i confirm that fix is working and no longer have local/current head issue. I think this PR can be merged now.

[gupadhyaya]

@nashqueue @tzdybal could you review this PR?

[MSevey]

need helper function needs a unit test