bump go version to 1.21 and use new builtin functions#1155
Merged
Conversation
Contributor
Author
|
need to bump ci to 1.21 as well |
tzdybal
reviewed
Aug 28, 2023
tzdybal
left a comment
Contributor
There was a problem hiding this comment.
Seems that switching to go 1.21 requires, quic-go update, and this requires libp2p update 🤔
Codewise LGTM.
d2d6322 to
950d6e6
Compare
gupadhyaya
approved these changes
Sep 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 55.45% 55.32% -0.14%
==========================================
Files 63 63
Lines 6699 6699
==========================================
- Hits 3715 3706 -9
- Misses 2589 2597 +8
- Partials 395 396 +1
☔ View full report in Codecov by Sentry. |
Manav-Aggarwal
approved these changes
Sep 1, 2023
Closed
Manav-Aggarwal
pushed a commit
that referenced
this pull request
Sep 6, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview ref #1125 remove cmmath as a dependency bump go version to 1.21 to use min and max builtin function s <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
…" (#1179) Ignite currently does not support go 1.21. So reverting this change until the support is added. This reverts commit 8981fd6. <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local> Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
Manav-Aggarwal
pushed a commit
that referenced
this pull request
Sep 13, 2023
…" (#1179) Ignite currently does not support go 1.21. So reverting this change until the support is added. This reverts commit 8981fd6. <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local> Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
chandiniv1
pushed a commit
to chandiniv1/rollkit
that referenced
this pull request
Sep 25, 2023
…ck#1155)" (evstack#1179) Ignite currently does not support go 1.21. So reverting this change until the support is added. This reverts commit 8981fd6. <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local> Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ref #1125
remove cmmath as a dependency
bump go version to 1.21 to use min and max builtin function s
Checklist