Enable subsecond block times using unix nano for Time in BaseHeader#1146
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
- Coverage 55.30% 55.22% -0.09%
==========================================
Files 62 62
Lines 6708 6709 +1
==========================================
- Hits 3710 3705 -5
- Misses 2603 2608 +5
- Partials 395 396 +1
☔ View full report in Codecov by Sentry. |
MSevey
suggested changes
Aug 17, 2023
MSevey
left a comment
Contributor
There was a problem hiding this comment.
minor change, otherwise looks good.
gupadhyaya
reviewed
Aug 17, 2023
6d923d3 to
115b705
Compare
115b705 to
1512ae0
Compare
1512ae0 to
e23e9dc
Compare
gupadhyaya
reviewed
Aug 17, 2023
Contributor
|
@Manav-Aggarwal did you test with an aggregator and full node and ensured that blocks are synced by the full node? just ensuring that this change does not lead to any regressions. |
Member
Author
yes |
gupadhyaya
approved these changes
Aug 17, 2023
nashqueue
approved these changes
Aug 17, 2023
MSevey
approved these changes
Aug 17, 2023
Manav-Aggarwal
added a commit
that referenced
this pull request
Sep 6, 2023
…1146) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closes: #1147 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #1147
Checklist