Skip to content

Use Blob Submit in Celestia DA Implementation#1141

Merged
Manav-Aggarwal merged 6 commits into
mainfrom
manav/use_blob_submit_celestia_Da
Aug 17, 2023
Merged

Use Blob Submit in Celestia DA Implementation#1141
Manav-Aggarwal merged 6 commits into
mainfrom
manav/use_blob_submit_celestia_Da

Conversation

@Manav-Aggarwal

@Manav-Aggarwal Manav-Aggarwal commented Aug 15, 2023

Copy link
Copy Markdown
Member

Overview

Closes: #1107

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/use_blob_submit_celestia_Da branch from 35a929f to 4531f02 Compare August 16, 2023 17:44
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/use_blob_submit_celestia_Da branch from 2e00e32 to 8ef819b Compare August 16, 2023 18:46
@codecov

codecov Bot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.15% 🎉

Comparison is base (91e1c64) 55.21% compared to head (41ce72a) 55.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   55.21%   55.36%   +0.15%     
==========================================
  Files          62       62              
  Lines        6719     6708      -11     
==========================================
+ Hits         3710     3714       +4     
+ Misses       2614     2599      -15     
  Partials      395      395              
Files Changed Coverage Δ
da/celestia/celestia.go 7.76% <0.00%> (+0.74%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review August 16, 2023 19:07
tuxcanfly
tuxcanfly previously approved these changes Aug 16, 2023

@tuxcanfly tuxcanfly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Comment thread da/celestia/celestia.go Outdated
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/use_blob_submit_celestia_Da branch from 82d7ff6 to 41ce72a Compare August 16, 2023 19:49

@tuxcanfly tuxcanfly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@MSevey MSevey added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit e0cc388 Aug 17, 2023
@Manav-Aggarwal Manav-Aggarwal deleted the manav/use_blob_submit_celestia_Da branch August 17, 2023 15:31
Manav-Aggarwal added a commit that referenced this pull request Sep 6, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes: #1107 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Blob.Submit instead of State.SubmitPayForBlob for submitting blocks on Celestia DA

3 participants