deps: fix celestia-openrpc v0.1.2 breaking changes#1140
Merged
Conversation
Bumps [github.com/rollkit/celestia-openrpc](https://github.com/rollkit/celestia-openrpc) from 0.1.1 to 0.1.2. - [Release notes](https://github.com/rollkit/celestia-openrpc/releases) - [Commits](celestiaorg/celestia-openrpc@v0.1.1...v0.1.2) --- updated-dependencies: - dependency-name: github.com/rollkit/celestia-openrpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 55.06% 55.33% +0.26%
==========================================
Files 62 62
Lines 6717 6717
==========================================
+ Hits 3699 3717 +18
+ Misses 2620 2606 -14
+ Partials 398 394 -4 ☔ View full report in Codecov by Sentry. |
gupadhyaya
approved these changes
Aug 15, 2023
Manav-Aggarwal
approved these changes
Aug 15, 2023
Manav-Aggarwal
pushed a commit
that referenced
this pull request
Sep 6, 2023
## Overview `celestia-openrpc v0.1.2` signature for `NewDataAvailabilityHeader` now returns an error, so this needed to be handled. `RandEDS` and `RandShares` needed to be updated for the new `Share` type. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
celestia-openrpc v0.1.2signature forNewDataAvailabilityHeadernow returns an error, so this needed to be handled.RandEDSandRandSharesneeded to be updated for the newSharetype.Checklist