For loop audit#1117
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
+ Coverage 55.52% 56.03% +0.51%
==========================================
Files 63 61 -2
Lines 6808 6555 -253
==========================================
- Hits 3780 3673 -107
+ Misses 2622 2490 -132
+ Partials 406 392 -14
☔ View full report in Codecov by Sentry. |
nashqueue
approved these changes
Aug 8, 2023
gupadhyaya
approved these changes
Aug 8, 2023
Manav-Aggarwal
pushed a commit
that referenced
this pull request
Sep 6, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview I did a quick audit of the code for infinite for loops to catch any remaining places where we might be hanging after a shutdown. This PR adds some comments to explain some test helpers and adds two select statements that watch for cancellation of subscriptions to help with a cleaner shutdown. <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> closes #1069 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I did a quick audit of the code for infinite for loops to catch any remaining places where we might be hanging after a shutdown.
This PR adds some comments to explain some test helpers and adds two select statements that watch for cancellation of subscriptions to help with a cleaner shutdown.
closes #1069
Checklist