Skip to content

Implement header interface for block and add block exchange service#1014

Merged
gupadhyaya merged 28 commits into
mainfrom
manav/rollkit_block_go_header_interface
Jun 26, 2023
Merged

Implement header interface for block and add block exchange service#1014
gupadhyaya merged 28 commits into
mainfrom
manav/rollkit_block_go_header_interface

Conversation

@Manav-Aggarwal

@Manav-Aggarwal Manav-Aggarwal commented Jun 15, 2023

Copy link
Copy Markdown
Member

Overview

Resolves #1005. resolves #1021

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov

codecov Bot commented Jun 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 51.17% and project coverage change: -0.23 ⚠️

Comparison is base (e4f8bd4) 54.95% compared to head (2f1c1c7) 54.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   54.95%   54.73%   -0.23%     
==========================================
  Files          60       63       +3     
  Lines        6423     6628     +205     
==========================================
+ Hits         3530     3628      +98     
- Misses       2537     2621      +84     
- Partials      356      379      +23     
Impacted Files Coverage Δ
node/header_exchange.go 53.07% <ø> (ø)
types/block.go 0.00% <0.00%> (ø)
block/manager.go 9.16% <25.00%> (+0.13%) ⬆️
node/block_exchange.go 51.40% <51.40%> (ø)
node/full.go 68.96% <72.72%> (+0.39%) ⬆️
node/test_helpers.go 80.64% <93.75%> (+1.01%) ⬆️
node/exchange.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread node/block_exchange.go
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go Outdated
Comment thread node/block_exchange.go
Comment thread node/block_exchange.go Outdated
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/rollkit_block_go_header_interface branch from 59c2d0e to 28bede7 Compare June 16, 2023 14:52
@Manav-Aggarwal Manav-Aggarwal changed the title Implement header interface for block Implement header interface for block and add block exchange service Jun 19, 2023
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review June 19, 2023 14:42
@Manav-Aggarwal Manav-Aggarwal requested a review from MSevey June 19, 2023 14:42
@Manav-Aggarwal Manav-Aggarwal added C:p2p p2p networking related C:block-sync labels Jun 19, 2023
@Manav-Aggarwal Manav-Aggarwal requested a review from nashqueue June 21, 2023 14:10
Comment thread block/manager.go
Comment thread node/exchange.go Outdated
Comment thread node/block_exchange.go
Comment thread node/block_exchange.go Outdated

@MSevey MSevey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would look even better with tests 😉

Comment thread node/block_exchange.go
Comment thread node/block_exchange.go Outdated
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/rollkit_block_go_header_interface branch from c36bfbc to 16064ae Compare June 23, 2023 17:15
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/rollkit_block_go_header_interface branch from 09149e6 to 3778e83 Compare June 23, 2023 21:30
@Manav-Aggarwal

Copy link
Copy Markdown
Member Author

Extracted the changes made to refactor header_exchange.go into #1028 since they make a test, LazyAggregator, in full_node_integration_test.go fail. Also, refactored tests to reuse the TestHeaderExchange tests in a new test called TestBlockExchange for testing Block Exchange Service.

@Manav-Aggarwal Manav-Aggarwal requested a review from MSevey June 23, 2023 21:42
Comment thread node/full_node_integration_test.go
@gupadhyaya gupadhyaya enabled auto-merge June 26, 2023 21:19
@gupadhyaya gupadhyaya added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 9564421 Jun 26, 2023
@gupadhyaya gupadhyaya deleted the manav/rollkit_block_go_header_interface branch June 26, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:block-sync C:p2p p2p networking related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Block Exchange Service Implement go-header interface for a Rollkit block

4 participants