Implement header interface for block and add block exchange service#1014
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
- Coverage 54.95% 54.73% -0.23%
==========================================
Files 60 63 +3
Lines 6423 6628 +205
==========================================
+ Hits 3530 3628 +98
- Misses 2537 2621 +84
- Partials 356 379 +23
☔ View full report in Codecov by Sentry. |
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
MSevey
reviewed
Jun 15, 2023
59c2d0e to
28bede7
Compare
gupadhyaya
reviewed
Jun 21, 2023
MSevey
reviewed
Jun 21, 2023
MSevey
reviewed
Jun 21, 2023
MSevey
reviewed
Jun 21, 2023
MSevey
suggested changes
Jun 21, 2023
MSevey
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Would look even better with tests 😉
gupadhyaya
reviewed
Jun 22, 2023
gupadhyaya
reviewed
Jun 22, 2023
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
c36bfbc to
16064ae
Compare
09149e6 to
3778e83
Compare
Member
Author
|
Extracted the changes made to refactor |
MSevey
reviewed
Jun 26, 2023
MSevey
approved these changes
Jun 26, 2023
gupadhyaya
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1005. resolves #1021
Checklist