Repository navigation
perf: give the split its own continuity clock, keep the joint path at 1 s - #179
Merged
Merged
Conversation
… 1 s One cap for every path at 2.5 s lifted the joint mean solve from 0.57 to 0.67 s within minutes, for a split improvement rate of 6.4 instead of 4.9 %. The joint path is 97 % of the traffic. The skip threshold and the joint cap go back to 1 s, the split keeps 2.5 s, both bounded by the deadline. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #178 from its first 12 minutes as revision 49.
CONTINUITY_TIME_LIMITwas both the skip threshold and the cap, so raising it to 2.5 s also pulled every joint solve up to 2.5 s into the stage and let it run that long. Joint mean solve went 0.57 to 0.67 s against revision 48, and the joint path is 97 % of the traffic. The split improvement rate moved 4.9 to 6.4 %.Two knobs now.
CONTINUITY_TIME_LIMITback to 1 s: the solve time above which the stage is not tried, and the cap on the joint path, which is what revision 48 ran.CONTINUITY_SPLIT_TIME_LIMIT2.5 s: the cap on a split, which has paid for a probe that proved nothing and ends around 5 to 6 s of the 10 s limit. Both bounded by the deadline in_continuity_clock.Test:
_continuity_clockreturns the path's cap and the deadline bound for both paths.🤖 Generated with Claude Code