Only one Client error log about Server error - #2053
Open
davidBar-On wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the PR, acknowledged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master 3.21+
Issues fixed (if any): JSON output (-J) emits two top-level "error" keys on server-relayed errors #2051
Brief description of code changes (suitable for use as a commit message):
Suggested fix to the issue that the client logs two error messages when receiving an error from the server, which may be a problem in JSON output.
The suggested solution is that the
SERVER ERRORprefix to the error text is added byiperf_strerror(), instead of logging a special error message (which causes the duplicate log). This is by negating the error code received from the server, which indicates toiperf_strerror()that this is a server error. In addition, handling of theerrnoreceived from the server was also added toiperf_strerror()