Repository navigation
fix(conversation): Allow forward slashes in ModelId validation - #96
Merged
Merged
Conversation
The `ModelId` validation has been updated to accept forward slashes as valid characters, enabling support for hierarchical model identifiers such as `openrouter/google/gemini-2.5-pro-preview`, where the first part (`openrouter`) is the provider, and the second part (`google/gemini-2.5-pro-preview`) is the model identifier used by Openrouter. The default persona configuration for the project has also been updated to fix the unknown model name. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ModelIdvalidation has been updated to accept forward slashes as valid characters, enabling support for hierarchical model identifiers such asopenrouter/google/gemini-2.5-pro-preview, where the first part (openrouter) is the provider, and the second part (google/gemini-2.5-pro-preview) is the model identifier used by Openrouter.The default persona configuration for the project has also been updated to fix the unknown model name.