Repository navigation
Conversation
Adds a draft RFD proposing a mechanism for local tools to author a separate display view of their result, distinct from the assistant view recorded into the conversation and replayed to the model. The motivation is that today the user always sees a projection of the same bytes the assistant sees. Two concrete cases need divergence: `fs_read_file` line gutters (numbered for the assistant, clean fenced for the terminal) and terse-summary-vs-full-dump patterns. The design introduces a third `Action` variant (`RewriteResult`) on `jp_tool::Action`. After a tool runs, JP invokes it once at turn time with the assistant view as input; the tool returns the display view, which is stored in tool-call event metadata and replayed from storage — mirroring the existing `FormatArguments` / `rendered_arguments` path. Divergence is opt-in via a default-off field on `conversation::tool` config, and scoped to local command tools only. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a draft RFD proposing a mechanism for local tools to author a separate display view of their result, distinct from the assistant view recorded into the conversation and replayed to the model.
The motivation is that today the user always sees a projection of the same bytes the assistant sees. Two concrete cases need divergence:
fs_read_fileline gutters (numbered for the assistant, clean fenced for the terminal) and terse-summary-vs-full-dump patterns.The design introduces a third
Actionvariant (RewriteResult) onjp_tool::Action. After a tool runs, JP invokes it once at turn time with the assistant view as input; the tool returns the display view, which is stored in tool-call event metadata and replayed from storage — mirroring the existingFormatArguments/rendered_argumentspath. Divergence is opt-in via a default-off field onconversation::toolconfig, and scoped to local command tools only.