Repository navigation
chore(tools): improve infrastructure and testability - #384
Merged
Merged
Conversation
Migrate from `std::path` to `camino` across `jp_tool` and project tooling to ensure UTF-8 path safety. This change simplifies path handling and prevents potential encoding issues when interacting with external processes. Introduce a `ProcessRunner` abstraction to decouple tool logic from the system shell. This enables unit testing of tools that invoke `git` or `cargo` by using a new `MockProcessRunner`, eliminating the need for complex integration tests that rely on the local environment. Refactor the `cargo`, `fs`, and `git` tool modules to use the new runner and improve consistency in error reporting. Additionally, enhance the XML serialization logic to better handle multiline strings and provide more readable output for LLM consumption. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
std::pathtocaminoacrossjp_tooland project tooling to ensure UTF-8 path safety. This change simplifies path handling and prevents potential encoding issues when interacting with external processes.Introduce a
ProcessRunnerabstraction to decouple tool logic from the system shell. This enables unit testing of tools that invokegitorcargoby using a newMockProcessRunner, eliminating the need for complex integration tests that rely on the local environment.Refactor the
cargo,fs, andgittool modules to use the new runner and improve consistency in error reporting. Additionally, enhance the XML serialization logic to better handle multiline strings and provide more readable output for LLM consumption.