Repository navigation
fix(cli): Apply conversation configuration from query args - #231
Merged
Merged
Conversation
Previously, any conversation-specific configuration was not being applied. This was due to a missing implementation of the `apply_conversation_config` method on the `Commands` enum. This commit adds the necessary implementation, ensuring that when `jp query` is executed, the configuration from the active conversation is correctly loaded and merged. This allows for per-conversation settings, such as a specific model or temperature, to be honored. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any conversation-specific configuration was not being applied. This was due to a missing implementation of the
apply_conversation_configmethod on theCommandsenum.This commit adds the necessary implementation, ensuring that when
jp queryis executed, the configuration from the active conversation is correctly loaded and merged. This allows for per-conversation settings, such as a specific model or temperature, to be honored.