Skip to content

fix(cli): Apply conversation configuration from query args - #231

Merged
JeanMertz merged 1 commit into
mainfrom
fix-conversation-config
Jul 24, 2025
Merged

JeanMertz merged 1 commit into
mainfrom
fix-conversation-config

Conversation

@JeanMertz

Copy link
Copy Markdown
Collaborator

Previously, any conversation-specific configuration was not being applied. This was due to a missing implementation of the apply_conversation_config method on the Commands enum.

This commit adds the necessary implementation, ensuring that when jp query is executed, the configuration from the active conversation is correctly loaded and merged. This allows for per-conversation settings, such as a specific model or temperature, to be honored.

Previously, any conversation-specific configuration was not being
applied. This was due to a missing implementation of the
`apply_conversation_config` method on the `Commands` enum.

This commit adds the necessary implementation, ensuring that when
`jp query` is executed, the configuration from the active conversation
is correctly loaded and merged. This allows for per-conversation
settings, such as a specific model or temperature, to be honored.

Signed-off-by: Jean Mertz <git@jeanmertz.com>
@JeanMertz
JeanMertz merged commit f834558 into main Jul 24, 2025
@JeanMertz
JeanMertz deleted the fix-conversation-config branch July 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant