Skip to content

fix(pf3): using flex-layout instead of float in pf3-form group.#90

Merged
Hyperkid123 merged 1 commit into
masterfrom
pf3-button-group
Aug 28, 2019
Merged

fix(pf3): using flex-layout instead of float in pf3-form group.#90
Hyperkid123 merged 1 commit into
masterfrom
pf3-button-group

Conversation

@Hyperkid123

Copy link
Copy Markdown
Member

Fixes pf3 buttons alignment. Swapped ButtonGroup with flex layout.

@Hyperkid123 Hyperkid123 added the bug Something isn't working label Aug 28, 2019
@Hyperkid123 Hyperkid123 requested a review from karelhala August 28, 2019 10:19
@codecov-io

codecov-io commented Aug 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #90 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   83.48%   83.42%   -0.07%     
==========================================
  Files          81       81              
  Lines        1344     1345       +1     
  Branches      318      318              
==========================================
  Hits         1122     1122              
- Misses        191      192       +1     
  Partials       31       31
Impacted Files Coverage Δ
...ges/react-form-renderer/src/form-renderer/index.js 73.68% <ø> (ø) ⬆️
...ponent-mapper/src/form-fields/layout-components.js 88.23% <66.66%> (-5.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad52125...d7bbfb9. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 6d8213e into master Aug 28, 2019
@Hyperkid123 Hyperkid123 deleted the pf3-button-group branch August 28, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants