Skip to content

fix(pf3select): props options was overwriting state#89

Merged
Hyperkid123 merged 1 commit into
data-driven-forms:masterfrom
rvsia:pf3-async
Aug 16, 2019
Merged

fix(pf3select): props options was overwriting state#89
Hyperkid123 merged 1 commit into
data-driven-forms:masterfrom
rvsia:pf3-async

Conversation

@rvsia

@rvsia rvsia commented Aug 16, 2019

Copy link
Copy Markdown
Contributor

Description

Empty props was overwriting state when async options.. because of new repo, it is not possible to track when it got broken. 👻

Thanks @andyvesel for reporting!

@rvsia rvsia added bug Something isn't working PF3 labels Aug 16, 2019
@rvsia rvsia requested a review from Hyperkid123 August 16, 2019 12:56
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files          81       81           
  Lines        1344     1344           
  Branches      318      318           
=======================================
  Hits         1122     1122           
  Misses        191      191           
  Partials       31       31
Impacted Files Coverage Δ
...3-component-mapper/src/form-fields/select/index.js 95.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b78aa...a236fb8. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit ad52125 into data-driven-forms:master Aug 16, 2019
@andyvesel

Copy link
Copy Markdown

@rvsia thanks! 👍
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1727920

@aufi

aufi commented Aug 27, 2019

Copy link
Copy Markdown

@Hyperkid123

Copy link
Copy Markdown
Member

@aufi can you create BZ and assign in to me (mmarosi@redhat.com). Or i can create it myself if you prefer.

@aufi

aufi commented Aug 27, 2019

Copy link
Copy Markdown

@Hyperkid123 I believe this should be part of https://bugzilla.redhat.com/show_bug.cgi?id=1727920 whic has been moved to ON_DEV due to pending update of yarn.lock. Thanks a lot!

@Hyperkid123

Copy link
Copy Markdown
Member

@aufi ok

@rvsia rvsia deleted the pf3-async branch September 17, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PF3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants