fix(pf4): Select styling.#87
Merged
Merged
Conversation
d10e9ea to
ccfa72b
Compare
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 81 81
Lines 1344 1344
Branches 318 318
=======================================
Hits 1122 1122
Misses 191 191
Partials 31 31
Continue to review full report at Codecov.
|
ccfa72b to
25f57cd
Compare
Contributor
|
The styling does make some strange things if you have a lot of items selected
Clearable + searchable
Only clearable
@Hyperkid123 If this is not a serious issue, then it's good to merge. |
25f57cd to
e877dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Padding on single select was off
Before:
After:
Fixed clear able button margin:
